linux-kernel - Re: [PATCH v11 08/16] PCI/ERR: Use "bridge" for clarity in pcie_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb655100-68c8-d1e9-9370-9a6f8104f41e@linux.intel.com>
Date:   Tue, 17 Nov 2020 13:59:47 -0800
From:   "Kuppuswamy, Sathyanarayanan" 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>
To:     Sean V Kelley <sean.v.kelley@...el.com>, bhelgaas@...gle.com,
        Jonathan.Cameron@...wei.com, xerces.zhao@...il.com,
        rafael.j.wysocki@...el.com, ashok.raj@...el.com,
        tony.luck@...el.com, sathyanarayanan.kuppuswamy@...el.com,
        qiuxu.zhuo@...el.com
Cc:     linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v11 08/16] PCI/ERR: Use "bridge" for clarity in
 pcie_do_recovery()



On 11/17/20 11:19 AM, Sean V Kelley wrote:
> pcie_do_recovery() may be called with "dev" being either a bridge (Root
> Port or Switch Downstream Port) or an Endpoint.  The bulk of the function
> deals with the bridge, so if we start with an Endpoint, we reset "dev" to
> be the bridge leading to it.
> 
> For clarity, replace "dev" in the body of the function with "bridge".  No
> functional change intended.
> 
> [bhelgaas: commit log, split pieces out so this is pure rename, also
> replace "dev" with "bridge" in messages and pci_uevent_ers()]
> Suggested-by: Bjorn Helgaas <bhelgaas@...gle.com>
> Link: https://lore.kernel.org/r/20201002184735.1229220-6-seanvk.dev@oregontracks.org
> Signed-off-by: Sean V Kelley <sean.v.kelley@...el.com>
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
> Acked-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>
> ---
>   drivers/pci/pcie/err.c | 37 ++++++++++++++++++++-----------------
>   1 file changed, 20 insertions(+), 17 deletions(-)
> 


-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer