linux-kernel - Re: [PATCH] Fix warning for static const char * array in audio_manager

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <X7NnJqKKvK1JfEHG@kroah.com>
Date:   Tue, 17 Nov 2020 07:01:10 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Emmanouil Perselis <perselis.e@...il.com>
Cc:     devel@...verdev.osuosl.org, elder@...nel.org, vaibhav.sr@...il.com,
        linux-kernel@...r.kernel.org, johan@...nel.org,
        mgreer@...malcreek.com, greybus-dev@...ts.linaro.org
Subject: Re: [PATCH] Fix warning for static const char * array in
 audio_manager_module.c

On Mon, Nov 16, 2020 at 09:43:23PM +0100, Emmanouil Perselis wrote:
> On 11/15/20 9:17 AM, Greg Kroah-Hartman wrote:
> > On Sun, Nov 15, 2020 at 03:53:16PM +0100, Emmanouil Perselis wrote:
> >> This patch fixes the warning "static const char * array should
> >> probably be static const char * const" in
> >> drivers/staging/greybus/audio_manager_module.c
> 
> >> I think Greg's patch bot is telling you that you need
> >> to carbon-copy the mailing list on your patch submission,
> >> not just address it to the maintainers.
> 
> Added addresses to carbon copy.

Do you think this is the correct way to submit a patch that doesn't have
to be hand-edited in order to apply it?

Please make it match other submitted patches, but most importantly,
actually test-build your changes to ensure that they are correct.

thanks,

greg k-h