linux-kernel - Re: [PATCH] rtw88: coex: remove the unreached code in rtw_coex_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ft58z94e.fsf@codeaurora.org>
Date:   Tue, 17 Nov 2020 10:21:37 +0200
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Pkshih <pkshih@...ltek.com>
Cc:     Tony Chuang <yhchuang@...ltek.com>,
        "xiakaixu1987\@gmail.com" <xiakaixu1987@...il.com>,
        "linux-wireless\@vger.kernel.org" <linux-wireless@...r.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        "kaixuxia\@tencent.com" <kaixuxia@...cent.com>
Subject: Re: [PATCH] rtw88: coex: remove the unreached code in rtw_coex_set_tdma

Pkshih <pkshih@...ltek.com> writes:

> On Sat, 2020-11-14 at 15:22 +0000, xiakaixu1987@...il.com wrote:
>> From: Kaixu Xia <kaixuxia@...cent.com>
>> 
>> The value of the bool variable ap_enable is always false, so the first
>> if branch is unreached code. Remove it.
>> 
>> Reported-by: Tosk Robot <tencent_os_robot@...cent.com>
>> Signed-off-by: Kaixu Xia <kaixuxia@...cent.com>
>> ---
>>  drivers/net/wireless/realtek/rtw88/coex.c | 12 +-----------
>>  1 file changed, 1 insertion(+), 11 deletions(-)
>> 
>> diff --git a/drivers/net/wireless/realtek/rtw88/coex.c
>> b/drivers/net/wireless/realtek/rtw88/coex.c
>> index aa08fd7d9fcd..9c7963e45755 100644
>> --- a/drivers/net/wireless/realtek/rtw88/coex.c
>> +++ b/drivers/net/wireless/realtek/rtw88/coex.c
>> @@ -863,18 +863,8 @@ static void rtw_coex_set_tdma(struct rtw_dev *rtwdev, u8
>> byte1, u8 byte2,
>>  	struct rtw_coex_dm *coex_dm = &coex->dm;
>>  	struct rtw_chip_info *chip = rtwdev->chip;
>>  	u8 ps_type = COEX_PS_WIFI_NATIVE;
>> -	bool ap_enable = false;
>
> The variable 'ap_enable' is used to indicate a vif is running in AP mode.
> At the first coex version, rtw88 doesn't support AP mode yet, so ap_enable
> is set to false. For now, AP mode is ready, and I can send a patch to set
> proper value depends on vif mode.
>
> Since I'm submitting coex patches to upgrade the code. In order to avoid
> conflicting, I'll send the patch to set proper ap_enable after all my patches
> are merged.

Ok, I'll then drop this.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches