linux-kernel - Re: [PATCH] irqchip/exiu: Fix the index of fwspec for IRQ type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXF+QoUwCdG=HL6Geyv8mxPTZF4PqEiFCXZm2kFQDC4N+Q@mail.gmail.com>
Date:   Tue, 17 Nov 2020 09:46:49 +0100
From:   Ard Biesheuvel <ardb@...nel.org>
To:     Chen Baozi <cbz@...zis.org>, Marc Zyngier <maz@...nel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] irqchip/exiu: Fix the index of fwspec for IRQ type

(+ Marc)

On Tue, 17 Nov 2020 at 04:20, Chen Baozi <cbz@...zis.org> wrote:
>
> From: Chen Baozi <chenbaozi@...tium.com.cn>
>
> Since fwspec->param_count of ACPI node is two, the index of IRQ type
> in fwspec->param[] should be 1 rather than 2.
>
> Signed-off-by: Chen Baozi <chenbaozi@...tium.com.cn>
> ---
>  drivers/irqchip/irq-sni-exiu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-sni-exiu.c b/drivers/irqchip/irq-sni-exiu.c
> index 1d027623c776..abd011fcecf4 100644
> --- a/drivers/irqchip/irq-sni-exiu.c
> +++ b/drivers/irqchip/irq-sni-exiu.c
> @@ -136,7 +136,7 @@ static int exiu_domain_translate(struct irq_domain *domain,
>                 if (fwspec->param_count != 2)
>                         return -EINVAL;
>                 *hwirq = fwspec->param[0];
> -               *type = fwspec->param[2] & IRQ_TYPE_SENSE_MASK;
> +               *type = fwspec->param[1] & IRQ_TYPE_SENSE_MASK;
>         }
>         return 0;
>  }
> --
> 2.28.0
>

Acked-by: Ard Biesheuvel <ardb@...nel.org>