linux-kernel - Re: [PATCH] checkpatch: Fix unescaped left brace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Nov 2020 14:37:38 +0530
From:   Dwaipayan Ray <dwaipayanray1@...il.com>
To:     Joe Perches <joe@...ches.com>,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] checkpatch: Fix unescaped left brace

On Tue, Nov 17, 2020 at 4:32 AM Joe Perches <joe@...ches.com> wrote:
>
> On Sun, 2020-11-15 at 19:43 -0800, Joe Perches wrote:
> > On Mon, 2020-11-16 at 01:59 +0530, Dwaipayan Ray wrote:
> > > There is an unescaped left brace in a regex in OPEN_BRACE
> > > check. This throws a runtime error when checkpatch is run
> > > with --fix flag and the OPEN_BRACE check is executed.
> > >
> > > Fix it by escaping the left brace.
> > >
> > > Fixes: 8d1824780f2f ("checkpatch: add --fix option for a couple OPEN_BRACE misuses")
> > > Signed-off-by: Dwaipayan Ray <dwaipayanray1@...il.com>
> >
> > Thanks Dwaipayan.
> >
> > Obviously that code path hasn't been tested in awhile.
> >
> > I think the notice to require an escape for a { was added back in
> > perl 5.16 or so.
>
> Just fyi:  it seems the requirement was actually implemented in perl 5.22
> and this code predates the release of perl 5.22
>
> https://github.com/Perl/perl5/blob/blead/pod/perl5220delta.pod
>
That's pretty interesting. Apart from that I have seen that
the perl_version_ok check mandates perl 5.10 which was
released more than 10 years back.

Do you think that check could be removed completely?
Maybe sometime in the future or just have it lay around
for backward compatibility?

Thanks,
Dwaipayan.