linux-kernel - Re: linux-next: build failure after merge of the mhi tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87blfwz6lw.fsf@codeaurora.org>
Date:   Tue, 17 Nov 2020 11:15:55 +0200
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Loic Poulain <loic.poulain@...aro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ath11k@...ts.infradead.org, linux-wireless@...r.kernel.org
Subject: Re: linux-next: build failure after merge of the mhi tree

Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org> writes:

> On Tue, Nov 17, 2020 at 09:53:59AM +0530, Manivannan Sadhasivam wrote:
>> +ath11k list, kalle
>> 
>
> Oops... adding now
>
>> On Tue, Nov 17, 2020 at 03:12:25PM +1100, Stephen Rothwell wrote:
>> > Hi all,
>> > 
>> > After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
>> > failed like this:
>> > 
>> > drivers/net/wireless/ath/ath11k/mhi.c:27:4: error: 'struct
>> > mhi_channel_config' has no member named 'auto_start'
>> >    27 |   .auto_start = false,
>> >       |    ^~~~~~~~~~
>> > drivers/net/wireless/ath/ath11k/mhi.c:42:4: error: 'struct
>> > mhi_channel_config' has no member named 'auto_start'
>> >    42 |   .auto_start = false,
>> >       |    ^~~~~~~~~~
>> > drivers/net/wireless/ath/ath11k/mhi.c:57:4: error: 'struct
>> > mhi_channel_config' has no member named 'auto_start'
>> >    57 |   .auto_start = true,
>> >       |    ^~~~~~~~~~
>> > drivers/net/wireless/ath/ath11k/mhi.c:72:4: error: 'struct
>> > mhi_channel_config' has no member named 'auto_start'
>> >    72 |   .auto_start = true,
>> >       |    ^~~~~~~~~~
>> > 
>> > Caused by commit
>> > 
>> >   0cc1f3a385b2 ("bus: mhi: Remove auto-start option")
>> > 
>> 
>> The fixing patch [1] should've landed in ath-next. Kalle can you please
>> apply the patch on top of immutable branch?
>> 
>> Stephen, feel free to pick it up in the meantime.

I think this fix should be included in commit 0cc1f3a385b2 ("bus: mhi:
Remove auto-start option"), otherwise the build will always fail. I can
then pull this commmit from the MHI immutable branch to my ath.git tree
and from there it will go to wireless-drivers-next.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches