linux-kernel - Re: [PATCH] drm/imx: depend on COMMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 17 Nov 2020 12:13:26 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Philipp Zabel <p.zabel@...gutronix.de>
Cc:     David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/imx: depend on COMMON_CLK to fix compile tests

On Tue, 17 Nov 2020 at 11:56, Philipp Zabel <p.zabel@...gutronix.de> wrote:
>
> On Mon, 2020-11-16 at 19:14 +0100, Krzysztof Kozlowski wrote:
> > The iMX DRM drivers use Common Clock Framework thus they cannot be built
> > on platforms without it (e.g. compile test on MIPS with RALINK and
> > SOC_RT305X):
> >
> >     /usr/bin/mips-linux-gnu-ld: drivers/gpu/drm/imx/imx-ldb.o: in function `imx_ldb_encoder_disable':
> >     imx-ldb.c:(.text+0x400): undefined reference to `clk_set_parent'
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
>
> Thank you, but could this be added to
>
> config DRM_IMX_LDB
>
> instead?
>
> The core DRM_IMX code does not use the Common Clock Framework directly.
> DRM_IMX_TVE already depends on COMMON_CLK because it implements a clock.

You're right, I even wanted to add it there but somehow it landed in
the main entry... Thanks, I'll send a v2.

Best regards,
Krzysztof