linux-kernel - Re: [PATCH 41/42] gpu/ipu-v3/ipu-di: Strip out 2 unused 'di_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c6a3ced0012d05bb33bb3ea765de359e480ad4a.camel@pengutronix.de>
Date:   Tue, 17 Nov 2020 12:22:53 +0100
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-kernel@...r.kernel.org,
        Sascha Hauer <s.hauer@...gutronix.de>,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 41/42] gpu/ipu-v3/ipu-di: Strip out 2 unused
 'di_sync_config' entries

Hi Lee,

On Mon, 2020-11-16 at 17:41 +0000, Lee Jones wrote:
> They're taking up too much space on the stack.
> 
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/gpu/ipu-v3/ipu-di.c: In function ‘ipu_di_sync_config_noninterlaced’:
>  drivers/gpu/ipu-v3/ipu-di.c:391:1: warning: the frame size of 1064 bytes is larger than 1024 bytes [-Wframe-larger-than=]
> 
> Cc: Philipp Zabel <p.zabel@...gutronix.de>
> Cc: Sascha Hauer <s.hauer@...gutronix.de>
> Cc: dri-devel@...ts.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/gpu/ipu-v3/ipu-di.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/ipu-v3/ipu-di.c b/drivers/gpu/ipu-v3/ipu-di.c
> index b4a31d506fccf..e617f60afeea3 100644
> --- a/drivers/gpu/ipu-v3/ipu-di.c
> +++ b/drivers/gpu/ipu-v3/ipu-di.c
> @@ -310,10 +310,6 @@ static void ipu_di_sync_config_noninterlaced(struct ipu_di *di,
>  			/* unused */
>  		} , {
>  			/* unused */
> -		} , {
> -			/* unused */
> -		} , {
> -			/* unused */
>  		},
>  	};
>  	/* can't use #7 and #8 for line active and pixel active counters */

Thank you, applied to imx-drm/next.

regards
Philipp