linux-kernel - Re: [PATCH -next] mmc: owl-mmc: use true and false for bool variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFr84zM8fu5KjHNWSQr4KyBVojbgDq82x_g90-VrFQiYLw@mail.gmail.com>
Date:   Tue, 17 Nov 2020 12:49:47 +0100
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Zou Wei <zou_wei@...wei.com>
Cc:     Andreas Färber <afaerber@...e.de>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] mmc: owl-mmc: use true and false for bool variables

On Mon, 9 Nov 2020 at 03:13, Zou Wei <zou_wei@...wei.com> wrote:
>
> Fix coccicheck warnings:
>
> ./owl-mmc.c:524:2-18: WARNING: Assignment of 0/1 to bool variable
> ./owl-mmc.c:528:2-18: WARNING: Assignment of 0/1 to bool variable
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/owl-mmc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c
> index 82d2bad..53b81582 100644
> --- a/drivers/mmc/host/owl-mmc.c
> +++ b/drivers/mmc/host/owl-mmc.c
> @@ -521,11 +521,11 @@ static void owl_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
>
>         /* Enable DDR mode if requested */
>         if (ios->timing == MMC_TIMING_UHS_DDR50) {
> -               owl_host->ddr_50 = 1;
> +               owl_host->ddr_50 = true;
>                 owl_mmc_update_reg(owl_host->base + OWL_REG_SD_EN,
>                                OWL_SD_EN_DDREN, true);
>         } else {
> -               owl_host->ddr_50 = 0;
> +               owl_host->ddr_50 = false;
>         }
>  }
>
> --
> 2.6.2
>