linux-kernel - Re: [PATCH RFC v2 4/5] net: stmmac: dwmac-meson8b: move RGMII delays into a separate function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201117020514.GD1752213@lunn.ch>
Date:   Tue, 17 Nov 2020 03:05:14 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Cc:     davem@...emloft.net, kuba@...nel.org,
        linux-amlogic@...ts.infradead.org, devicetree@...r.kernel.org,
        robh+dt@...nel.org, netdev@...r.kernel.org,
        jianxin.pan@...ogic.com, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, khilman@...libre.com,
        narmstrong@...libre.com, jbrunet@...libre.com, f.fainelli@...il.com
Subject: Re: [PATCH RFC v2 4/5] net: stmmac: dwmac-meson8b: move RGMII delays
 into a separate function

On Sun, Nov 15, 2020 at 07:52:09PM +0100, Martin Blumenstingl wrote:
> Newer SoCs starting with the Amlogic Meson G12A have more a precise
> RGMII RX delay configuration register. This means more complexity in the
> code. Extract the existing RGMII delay configuration code into a
> separate function to make it easier to read/understand even when adding
> more logic in the future.
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew