linux-kernel - Re: [PATCH v2 1/3] soc: qcom: Add tracepoints to mdt loader

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202011171027.SMpqs92W-lkp@intel.com>
Date:   Tue, 17 Nov 2020 10:14:35 +0800
From:   kernel test robot <lkp@...el.com>
To:     Rishabh Bhatnagar <rishabhb@...eaurora.org>,
        linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, bjorn.andersson@...aro.org,
        tsoni@...eaurora.org, psodagud@...eaurora.org,
        sidgup@...eaurora.org, Rishabh Bhatnagar <rishabhb@...eaurora.org>
Subject: Re: [PATCH v2 1/3] soc: qcom: Add tracepoints to mdt loader

Hi Rishabh,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/perf/core]
[also build test WARNING on linux/master linus/master v5.10-rc4 next-20201116]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Rishabh-Bhatnagar/Add-events-to-trace-remoteproc-lifecycle/20201117-054729
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 306e3e91edf1c6739a55312edd110d298ff498dd
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/437cc5c0ceb1f4b36564b99d7289af089576fdd0
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Rishabh-Bhatnagar/Add-events-to-trace-remoteproc-lifecycle/20201117-054729
        git checkout 437cc5c0ceb1f4b36564b99d7289af089576fdd0
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from include/trace/define_trace.h:102,
                    from include/trace/events/mdt_loader.h:38,
                    from drivers/soc/qcom/mdt_loader.c:21:
   include/trace/events/mdt_loader.h: In function 'trace_raw_output_qcom_mdt_load_segment':
>> include/trace/events/mdt_loader.h:33:12: warning: format '%p' expects argument of type 'void *', but argument 4 has type 'phys_addr_t' {aka 'unsigned int'} [-Wformat=]
      33 |  TP_printk("firmware:%s region start=%pa size=%zx",
         |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/trace/trace_events.h:367:22: note: in definition of macro 'DECLARE_EVENT_CLASS'
     367 |  trace_seq_printf(s, print);     \
         |                      ^~~~~
   include/trace/trace_events.h:80:9: note: in expansion of macro 'PARAMS'
      80 |         PARAMS(print));         \
         |         ^~~~~~
   include/trace/events/mdt_loader.h:15:1: note: in expansion of macro 'TRACE_EVENT'
      15 | TRACE_EVENT(qcom_mdt_load_segment,
         | ^~~~~~~~~~~
   include/trace/events/mdt_loader.h:33:2: note: in expansion of macro 'TP_printk'
      33 |  TP_printk("firmware:%s region start=%pa size=%zx",
         |  ^~~~~~~~~
   In file included from include/trace/trace_events.h:401,
                    from include/trace/define_trace.h:102,
                    from include/trace/events/mdt_loader.h:38,
                    from drivers/soc/qcom/mdt_loader.c:21:
   include/trace/events/mdt_loader.h:33:39: note: format string is defined here
      33 |  TP_printk("firmware:%s region start=%pa size=%zx",
         |                                      ~^
         |                                       |
         |                                       void *
         |                                      %d

vim +33 include/trace/events/mdt_loader.h

    16	
    17		TP_PROTO(phys_addr_t region_start, size_t region_size, const char *fw),
    18	
    19		TP_ARGS(region_start, region_size, fw),
    20	
    21		TP_STRUCT__entry(
    22			__field(phys_addr_t, region_start)
    23			__field(size_t, region_size)
    24			__string(fw, fw)
    25		),
    26	
    27		TP_fast_assign(
    28			__entry->region_start = region_start;
    29			__entry->region_size = region_size;
    30			__assign_str(fw, fw);
    31		),
    32	
  > 33		TP_printk("firmware:%s region start=%pa size=%zx",
    34			  __get_str(fw), __entry->region_start, __entry->region_size)
    35	);
    36	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (76510 bytes)