[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20201118202742.GA15147@embeddedor>
Date: Wed, 18 Nov 2020 14:27:42 -0600
From: "Gustavo A. R. Silva" <gustavoars@...nel.org>
To: Nick Desaulniers <ndesaulniers@...gle.com>
Cc: Nathan Chancellor <natechancellor@...il.com>,
Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
Michael Ellerman <mpe@...erman.id.au>,
Benjamin Herrenschmidt <benh@...nel.crashing.org>,
Paul Mackerras <paulus@...ba.org>,
clang-built-linux@...glegroups.com, linuxppc-dev@...ts.ozlabs.org,
linux-kernel@...r.kernel.org, Arvind Sankar <nivedita@...m.mit.edu>
Subject: Re: [PATCH v2 0/3] PPC: Fix -Wimplicit-fallthrough for clang
Nick,
On Tue, Nov 17, 2020 at 04:07:48PM -0800, Nick Desaulniers wrote:
> While cleaning up the last few -Wimplicit-fallthrough warnings in tree
> for Clang, I noticed
> commit 6a9dc5fd6170d ("lib: Revert use of fallthrough pseudo-keyword in lib/")
> which seemed to undo a bunch of fixes in lib/ due to breakage in
> arch/powerpc/boot/ not including compiler_types.h. We don't need
> compiler_types.h for the definition of `fallthrough`, simply
> compiler_attributes.h. Include that, revert the revert to lib/, and fix
> the last remaining cases I observed for powernv_defconfig.
I've added the series to my -next tree, together with Miguel's
suggestions.
Thanks for the Acks and comments, Michael.
--
Gustavo
Powered by blists - more mailing lists