linux-kernel - Re: [PATCH v11 16/16] PCI/AER: Add RCEC AER error injection support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <723cf380-fa03-c6ca-ec9c-a8ee562d23b8@linux.intel.com>
Date:   Tue, 17 Nov 2020 22:02:22 -0800
From:   "Kuppuswamy, Sathyanarayanan" 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>
To:     Sean V Kelley <sean.v.kelley@...el.com>, bhelgaas@...gle.com,
        Jonathan.Cameron@...wei.com, xerces.zhao@...il.com,
        rafael.j.wysocki@...el.com, ashok.raj@...el.com,
        tony.luck@...el.com, sathyanarayanan.kuppuswamy@...el.com,
        qiuxu.zhuo@...el.com
Cc:     linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v11 16/16] PCI/AER: Add RCEC AER error injection support



On 11/17/20 11:19 AM, Sean V Kelley wrote:
> From: Qiuxu Zhuo <qiuxu.zhuo@...el.com>
> 
> Root Complex Event Collectors (RCEC) appear as peers to Root Ports and may
> also have the AER capability.
> 
> Add RCEC support to the AER error injection driver.
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>
> 
> Co-developed-by: Sean V Kelley <sean.v.kelley@...el.com>
> Link: https://lore.kernel.org/r/20201002184735.1229220-15-seanvk.dev@oregontracks.org
> Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@...el.com>
> Signed-off-by: Sean V Kelley <sean.v.kelley@...el.com>
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
> ---
>   drivers/pci/pcie/aer_inject.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/pcie/aer_inject.c b/drivers/pci/pcie/aer_inject.c
> index c2cbf425afc5..767f8859b99b 100644
> --- a/drivers/pci/pcie/aer_inject.c
> +++ b/drivers/pci/pcie/aer_inject.c
> @@ -333,8 +333,11 @@ static int aer_inject(struct aer_error_inj *einj)
>   	if (!dev)
>   		return -ENODEV;
>   	rpdev = pcie_find_root_port(dev);
> +	/* If Root Port not found, try to find an RCEC */
> +	if (!rpdev)
> +		rpdev = dev->rcec;
>   	if (!rpdev) {
> -		pci_err(dev, "Root port not found\n");
> +		pci_err(dev, "Neither Root Port nor RCEC found\n");
>   		ret = -ENODEV;
>   		goto out_put;
>   	}
> 

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer