linux-kernel - Re: [PATCH] Changes since v1 - Change subject form "ALSA" to "USB:"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <X7TGU+JHUL4eTbG6@kroah.com>
Date:   Wed, 18 Nov 2020 07:59:31 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     penghao <penghao@...ontech.com>
Cc:     johan@...nel.org, jonathan@...ox.net, tomasz@...esinski.eu,
        hdegoede@...hat.com, dlaz@...omium.org,
        kai.heng.feng@...onical.com, richard.o.dodd@...il.com,
        kerneldev@...smulder.nl, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Changes since v1  - Change subject form "ALSA" to "USB:"
 - Adjust to approoriate line

On Wed, Nov 18, 2020 at 02:51:32PM +0800, penghao wrote:
> USB: quirks: Add USB_QUIRK_DISCONNECT_SUSPEND quirk for
> Lenovo A630Z TIO built-in usb-audio card

Your subject line does not work, please put that information below the
--- line.

Also, we need a "real" name for the From: and signed-off-by line please.

> Add a USB_QUIRK_DISCONNECT_SUSPEND quirk for the Lenovo TIO built-in
> usb-audio. when A630Z going into S3,the system immediately wakeup 7-8
> seconds later by usb-audio disconnect interrupt to avoids the issue.
> 
> Seeking a better fix, we've tried a lot of things, including:
>  - Check that the device's power/wakeup is disabled
>  - Check that remote wakeup is off at the USB level
>  - All the quirks in drivers/usb/core/quirks.c
>    e.g. USB_QUIRK_RESET_RESUME,
>         USB_QUIRK_RESET,
>         USB_QUIRK_IGNORE_REMOTE_WAKEUP,
>         USB_QUIRK_NO_LPM.
> 
> but none of that makes any difference.
> 
> There are no errors in the logs showing any suspend/resume-related issues.
> When the system wakes up due to the modem, log-wise it appears to be a
> normal resume.
> 
> Introduce a quirk to disable the port during suspend when the modem is
> detected.
> 
> Signed-off-by: penghao <penghao@...ontech.com>
> ---
>  drivers/usb/core/quirks.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 7c1198f80c23..8d18e89f9eb0 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -410,7 +410,11 @@ static const struct usb_device_id usb_quirk_list[] = {
>  	{ USB_DEVICE(0x1532, 0x0116), .driver_info =
>  			USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
>  
> -	/* BUILDWIN Photo Frame */
> +/* Lenovo - ThinkCenter A630Z TI024Gen3 usb-audio card */
> +{ USB_DEVICE(0x17ef, 0x0xa012), .driver_info =
> +USB_QUIRK_DISCONNECT_SUSPEND },
> +
> +    /* BUILDWIN Photo Frame */

Your patch seems to have messed up spaces and tabs here, please fix that
up in your editor and always run scripts/checkpatch.pl on your patch
before resending it.

thanks,

greg k-h