[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAPcyv4iECY-XoJ=jhARDDqjv-j8fnOUiKxB9Z+M5J+kMoeeWhA@mail.gmail.com>
Date: Wed, 18 Nov 2020 00:08:03 -0800
From: Dan Williams <dan.j.williams@...el.com>
To: Zhen Lei <thunder.leizhen@...wei.com>
Cc: Vishal Verma <vishal.l.verma@...el.com>,
Dave Jiang <dave.jiang@...el.com>,
Ira Weiny <ira.weiny@...el.com>,
"Rafael J . Wysocki" <rjw@...ysocki.net>,
Len Brown <lenb@...nel.org>,
linux-nvdimm <linux-nvdimm@...ts.01.org>,
linux-acpi <linux-acpi@...r.kernel.org>,
linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] ACPI/nfit: avoid accessing uninitialized memory in acpi_nfit_ctl()
On Tue, Nov 17, 2020 at 11:36 PM Zhen Lei <thunder.leizhen@...wei.com> wrote:
>
> The ACPI_ALLOCATE() does not zero the "buf", so when the condition
> "integer->type != ACPI_TYPE_INTEGER" in int_to_buf() is met, the result
> is unpredictable in acpi_nfit_ctl().
>
> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>
Looks good to me.
Reviewed-by: Dan Williams <dan.j.williams@...el.com>
I'll pick this up.
Powered by blists - more mailing lists