linux-kernel - Re: [PATCH] amd/amdgpu: use kmalloc_array to replace kmalloc with multiply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f55ec782-9eff-c30b-2a0e-01a9898c9387@amd.com>
Date:   Wed, 18 Nov 2020 09:17:49 +0100
From:   Christian König <christian.koenig@....com>
To:     Bernard Zhao <bernard@...o.com>,
        Alex Deucher <alexander.deucher@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, Monk Liu <Monk.Liu@....com>,
        Hawking Zhang <Hawking.Zhang@....com>,
        Yintian Tao <yttao@....com>, Dennis Li <Dennis.Li@....com>,
        Wenhui Sheng <Wenhui.Sheng@....com>,
        chen gong <curry.gong@....com>,
        Bokun Zhang <Bokun.Zhang@....com>,
        "Stanley.Yang" <Stanley.Yang@....com>,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Cc:     opensource.kernel@...o.com
Subject: Re: [PATCH] amd/amdgpu: use kmalloc_array to replace kmalloc with
 multiply

Am 18.11.20 um 03:55 schrieb Bernard Zhao:
> Fix check_patch.pl warning:
> WARNING: Prefer kmalloc_array over kmalloc with multiply
> +bps = kmalloc(align_space * sizeof((*data)->bps), GFP_KERNEL);
> WARNING: Prefer kmalloc_array over kmalloc with multiply
> +bps_bo = kmalloc(align_space * sizeof((*data)->bps_bo),
> GFP_KERNEL);
> kmalloc_array has multiply overflow check, which will be safer.
>
> Signed-off-by: Bernard Zhao <bernard@...o.com>

Not userspace controllable values, but looks cleaner anyway.

Reviewed-by: Christian König <christian.koenig@....com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> index d0aea5e39531..f2a0851c804f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> @@ -280,8 +280,8 @@ static int amdgpu_virt_init_ras_err_handler_data(struct amdgpu_device *adev)
>   	if (!*data)
>   		return -ENOMEM;
>   
> -	bps = kmalloc(align_space * sizeof((*data)->bps), GFP_KERNEL);
> -	bps_bo = kmalloc(align_space * sizeof((*data)->bps_bo), GFP_KERNEL);
> +	bps = kmalloc_array(align_space, sizeof((*data)->bps), GFP_KERNEL);
> +	bps_bo = kmalloc_array(align_space, sizeof((*data)->bps_bo), GFP_KERNEL);
>   
>   	if (!bps || !bps_bo) {
>   		kfree(bps);