lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 18 Nov 2020 09:29:06 +0100 From: Bartosz Golaszewski <bgolaszewski@...libre.com> To: Greentime Hu <greentime.hu@...ive.com> Cc: LKML <linux-kernel@...r.kernel.org>, Linus Walleij <linus.walleij@...aro.org>, linux-gpio <linux-gpio@...r.kernel.org>, linux-riscv@...ts.infradead.org, Palmer Dabbelt <palmer@...belt.com>, Paul Walmsley <paul.walmsley@...ive.com>, Andy Shevchenko <andy.shevchenko@...il.com>, Yash Shah <yash.shah@...ive.com> Subject: Re: [PATCH v3] gpio: sifive: To get gpio irq offset from device tree data On Fri, Nov 13, 2020 at 3:34 AM Greentime Hu <greentime.hu@...ive.com> wrote: > > We can get hwirq number of the gpio by its irq_data->hwirq so that we don't > need to add more macros for different platforms. This patch is tested in > SiFive Unleashed board and SiFive Unmatched board. > > Signed-off-by: Greentime Hu <greentime.hu@...ive.com> > --- > drivers/gpio/gpio-sifive.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpio/gpio-sifive.c b/drivers/gpio/gpio-sifive.c > index c54dd08f2cbf..630bddec48e5 100644 > --- a/drivers/gpio/gpio-sifive.c > +++ b/drivers/gpio/gpio-sifive.c > @@ -29,7 +29,6 @@ > #define SIFIVE_GPIO_OUTPUT_XOR 0x40 > > #define SIFIVE_GPIO_MAX 32 > -#define SIFIVE_GPIO_IRQ_OFFSET 7 > > struct sifive_gpio { > void __iomem *base; > @@ -37,7 +36,7 @@ struct sifive_gpio { > struct regmap *regs; > unsigned long irq_state; > unsigned int trigger[SIFIVE_GPIO_MAX]; > - unsigned int irq_parent[SIFIVE_GPIO_MAX]; > + unsigned int irq_number[SIFIVE_GPIO_MAX]; > }; > > static void sifive_gpio_set_ie(struct sifive_gpio *chip, unsigned int offset) > @@ -144,8 +143,12 @@ static int sifive_gpio_child_to_parent_hwirq(struct gpio_chip *gc, > unsigned int *parent, > unsigned int *parent_type) > { > + struct sifive_gpio *chip = gpiochip_get_data(gc); > + struct irq_data *d = irq_get_irq_data(chip->irq_number[child]); > + > *parent_type = IRQ_TYPE_NONE; > - *parent = child + SIFIVE_GPIO_IRQ_OFFSET; > + *parent = irqd_to_hwirq(d); > + > return 0; > } > > @@ -165,7 +168,7 @@ static int sifive_gpio_probe(struct platform_device *pdev) > struct irq_domain *parent; > struct gpio_irq_chip *girq; > struct sifive_gpio *chip; > - int ret, ngpio; > + int ret, ngpio, i; > > chip = devm_kzalloc(dev, sizeof(*chip), GFP_KERNEL); > if (!chip) > @@ -200,6 +203,9 @@ static int sifive_gpio_probe(struct platform_device *pdev) > return -ENODEV; > } > > + for (i = 0; i < ngpio; i++) > + chip->irq_number[i] = platform_get_irq(pdev, i); > + > ret = bgpio_init(&chip->gc, dev, 4, > chip->base + SIFIVE_GPIO_INPUT_VAL, > chip->base + SIFIVE_GPIO_OUTPUT_VAL, > -- > 2.29.2 > Applied, thanks! Bart
Powered by blists - more mailing lists