linux-kernel - Re: [PATCH] drivers: gpio: use of_match_ptr() and ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Nov 2020 10:08:56 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        "Enrico Weigelt, metux IT consult" <info@...ux.net>,
        Jonathan Cameron <jic23@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-tegra@...r.kernel.org,
        Thierry Reding <thierry.reding@...il.com>,
        Alban Bedel <albeu@...e.fr>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Kevin Hilman <khilman@...nel.org>, zhang.lyra@...il.com,
        Marek Behún <marek.behun@....cz>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
        dl-linux-imx <linux-imx@....com>, orsonzhai@...il.com,
        Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>,
        linux-pwm@...r.kernel.org,
        Grygorii Strashko <grygorii.strashko@...com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Vladimir Zapolskiy <vz@...ia.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Fabio Estevam <festevam@...il.com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Linux OMAP Mailing List <linux-omap@...r.kernel.org>,
        Hoan Tran <hoan@...amperecomputing.com>,
        Scott Branden <sbranden@...adcom.com>,
        Andrew Jeffery <andrew@...id.au>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Serge Semin <fancer.lancer@...il.com>,
        Sascha Hauer <kernel@...gutronix.de>, baolin.wang7@...il.com,
        Shawn Guo <shawnguo@...nel.org>
Subject: Re: [PATCH] drivers: gpio: use of_match_ptr() and ACPI_PTR() macros

On Wed, 18 Nov 2020, Andy Shevchenko wrote:

> On Wed, Nov 18, 2020 at 11:56 AM Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
> > On Wed, Nov 18, 2020 at 11:54 AM Uwe Kleine-König
> > <u.kleine-koenig@...gutronix.de> wrote:
> > > On Tue, Nov 17, 2020 at 06:45:37PM +0200, Andy Shevchenko wrote:
> 
> ...
> 
> > > So a system without CONFIG_OF might still make use of .of_match_table?
> >
> > Yep!
> 
> If you are curious:
> https://elixir.bootlin.com/linux/latest/source/drivers/acpi/bus.c#L615

This still doesn't sit quite well with me.

Not the process of ACPI using OF artifacts or the possibilty to embed
OF type structures into ACPI tables, but the fact that an OF-only user
(or so they think) should have to care about that special use-case.

What if we make ACPI select OF?  Or handle the ACPI case explicitly in
the of_match_ptr() declaration?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog