[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20201118105945.GF4556@piout.net>
Date: Wed, 18 Nov 2020 11:59:45 +0100
From: Alexandre Belloni <alexandre.belloni@...tlin.com>
To: Gregory CLEMENT <gregory.clement@...tlin.com>
Cc: Sebastian Reichel <sre@...nel.org>, linux-pm@...r.kernel.org,
linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
devicetree@...r.kernel.org,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
Lars Povlsen <lars.povlsen@...rochip.com>,
Steen.Hegelund@...rochip.com
Subject: Re: [PATCH 1/5] dt-bindings: reset: ocelot: Add documentation for
'microchip,reset-switch-core' property
On 16/11/2020 18:11:55+0100, Gregory CLEMENT wrote:
> From: Lars Povlsen <lars.povlsen@...rochip.com>
>
> This documents the 'microchip,reset-switch-core' property in the
> ocelot-reset driver.
>
> Signed-off-by: Lars Povlsen <lars.povlsen@...rochip.com>
> ---
> .../devicetree/bindings/power/reset/ocelot-reset.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/reset/ocelot-reset.txt b/Documentation/devicetree/bindings/power/reset/ocelot-reset.txt
> index 4d530d815484..20fff03753ad 100644
> --- a/Documentation/devicetree/bindings/power/reset/ocelot-reset.txt
> +++ b/Documentation/devicetree/bindings/power/reset/ocelot-reset.txt
> @@ -9,9 +9,15 @@ microchip Sparx5 armv8 SoC's.
> Required Properties:
> - compatible: "mscc,ocelot-chip-reset" or "microchip,sparx5-chip-reset"
>
> +Optional properties:
> +- microchip,reset-switch-core : Perform a switch core reset at the
> + time of driver load. This is may be used to initialize the switch
> + core to a known state (before other drivers are loaded).
> +
If this is to be used by the switchdev driver, then I would simply
register this reset as a proper reset controller (with the driver/reset
API) and consume that from the switchdev driver.
However, the switch may also be configured from userspace in existing
products. In this case you'd have to expose a reset interface, either
from the drivers/reset core or with a specific consumer.
My point is that this property is not necessary.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Powered by blists - more mailing lists