linux-kernel - Re: [PATCH] pwm: add missed clk_disable_unprepare() in zx_pwm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201118123707.ab5euxfvljsoi6md@pengutronix.de>
Date:   Wed, 18 Nov 2020 13:37:07 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Zhang Changzhong <zhangchangzhong@...wei.com>
Cc:     thierry.reding@...il.com, lee.jones@...aro.org,
        shawn.guo@...aro.org, linux-pwm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pwm: add missed clk_disable_unprepare() in zx_pwm_probe()

Hello,

On Wed, Nov 18, 2020 at 08:26:24PM +0800, Zhang Changzhong wrote:
> Add the missing clk_disable_unprepare() before return from
> zx_pwm_probe() in the error handling case.
> 
> Fixes: 4836193c435c ("pwm: Add ZTE ZX PWM device driver")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@...wei.com>
> ---
>  drivers/pwm/pwm-zx.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pwm/pwm-zx.c b/drivers/pwm/pwm-zx.c
> index e2c21cc..3763ce5 100644
> --- a/drivers/pwm/pwm-zx.c
> +++ b/drivers/pwm/pwm-zx.c
> @@ -238,6 +238,7 @@ static int zx_pwm_probe(struct platform_device *pdev)
>  	ret = pwmchip_add(&zpc->chip);
>  	if (ret < 0) {
>  		dev_err(&pdev->dev, "failed to add PWM chip: %d\n", ret);
> +		clk_disable_unprepare(zpc->pclk);
>  		return ret;

This is already fixed in next with:

	a278e8771f42 ("pwm: zx: Add missing cleanup in error path")

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)