linux-kernel - Re: [PATCH v3 1/3] tools/bootconfig: Fix to check the write failure correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20201118223708.4b196db7bc1030f7604876ad@kernel.org>
Date:   Wed, 18 Nov 2020 22:37:08 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Chen Yu <yu.chen.surf@...il.com>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Chen Yu <yu.c.chen@...el.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH v3 1/3] tools/bootconfig: Fix to check the write failure
 correctly

On Tue, 17 Nov 2020 20:10:10 +0800
Chen Yu <yu.chen.surf@...il.com> wrote:

> On Tue, Nov 17, 2020 at 5:53 PM Masami Hiramatsu <mhiramat@...nel.org> wrote:
> >
> > Fix to check the write(2) failure including partial write
> > correctly and try to rollback the partial write, because
> > if there is no BOOTCONFIG_MAGIC string, we can not remove it.
> >
> > Fixes: 85c46b78da58 ("bootconfig: Add bootconfig magic word for indicating bootconfig explicitly")
> > Suggested-by: Linus Torvalds <torvalds@...ux-foundation.org>
> > Signed-off-by: Masami Hiramatsu <mhiramat@...nel.org>
> For [1/3] and [2/3]
> Tested-by: Chen Yu <yu.chen.surf@...il.com>

Thank you Chen,

BTW, I found another bug in bootconfig error handling.
Steve, did you already pick this series? If not yet, I will update the seires to add that fix.

Thank you,

> 
> -- 
> Thanks,
> Chenyu


-- 
Masami Hiramatsu <mhiramat@...nel.org>