linux-kernel - Re: Can you help diagnose a weird failed wake?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201119163327.GT3121392@hirez.programming.kicks-ass.net>
Date:   Thu, 19 Nov 2020 17:33:27 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     David Howells <dhowells@...hat.com>
Cc:     paulmck@...nel.org, jlayton@...hat.com, willy@...radead.org,
        linux-cachefs@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: Can you help diagnose a weird failed wake?

On Thu, Nov 19, 2020 at 03:53:42PM +0000, David Howells wrote:

> 		timeo = wait_var_event_timeout(&cookie->stage, cookie_stage_changed(cookie, stage), 10*HZ);

> 			cookie->stage = stage;                                                              
> 			changed = true;                                                                    
> 			break;                                                                              
> 		}                                                                                          
> 		spin_unlock(&cookie->lock);                                                                
> 		if (changed) {                                                                              

smp_mb(); // see comment on wake_up_bit() / wakequeue_active()

> 			wake_up_var(&cookie->stage);