linux-kernel - Re: [PATCH v6 8/8] rpmsg: Turn name service into a stand alone driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201119173332.GA94178@xps15>
Date:   Thu, 19 Nov 2020 10:33:32 -0700
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     Guennadi Liakhovetski <guennadi.liakhovetski@...ux.intel.com>
Cc:     Arnaud POULIQUEN <arnaud.pouliquen@...com>,
        "ohad@...ery.com" <ohad@...ery.com>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        "linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 8/8] rpmsg: Turn name service into a stand alone driver

On Thu, Nov 19, 2020 at 06:10:51PM +0100, Guennadi Liakhovetski wrote:
> Hi Mathieu,
> 
> I haven't tested it yet, but I've compared it to the previous version 
> and all the changed except the one, mentioned by Arnaud, seem to be 
> there! So, let's just fix this one and should be good to go!
>

Apologies for the brain bug - the code got lost in the thread...
 
> Thanks
> Guennadi
> 
> On Thu, Nov 19, 2020 at 03:52:50PM +0100, Arnaud POULIQUEN wrote:
> 
> [snip]
> 
> > As Guennadi mentionned in a previous mail
> > a kfree(vch) is missing on error
> > 
> > @@ -949,10 +949,11 @@ static int rpmsg_probe(struct virtio_device *vdev)
> >  	dev_info(&vdev->dev, "rpmsg host is online\n");
> > 
> >  	return 0;
> > 
> >  free_coherent:
> > +	kfree(vch);
> >  	dma_free_coherent(vdev->dev.parent, total_buf_space,
> >  			  bufs_va, vrp->bufs_dma);
> >  vqs_del:
> > 
> > Otherwise i tested this series successfully.
> > 
> > Thanks,
> > Arnaud