linux-kernel - Re: [PATCH v2] mm: hugetlb: fix type of delta parameter and related local variables in gather_surplus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9dbafb55-a1f7-7f6e-d0e9-00dfabc8e2b6@oracle.com>
Date:   Thu, 19 Nov 2020 10:34:19 -0800
From:   Mike Kravetz <mike.kravetz@...cle.com>
To:     Liu Xiang <liu.xiang@...ngsmart.com>, linux-mm@...ck.org
Cc:     akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
        liuxiang_1999@....com, Pan Jiagen <pan.jiagen@...ngsmart.com>
Subject: Re: [PATCH v2] mm: hugetlb: fix type of delta parameter and related
 local variables in gather_surplus_pages()

On 11/19/20 5:48 AM, Liu Xiang wrote:
> On 64-bit machine, delta variable in hugetlb_acct_memory() may be larger
> than 0xffffffff, but gather_surplus_pages() can only use the low 32-bit
> value now. So we need to fix type of delta parameter and related local
> variables in gather_surplus_pages().
> 
> Reported-by: Ma Chenggong <ma.chenggong@...ngsmart.com>
> Signed-off-by: Liu Xiang <liu.xiang@...ngsmart.com>
> Signed-off-by: Pan Jiagen <pan.jiagen@...ngsmart.com>
> 
> ---
> Changes in v2:
>   as suggested by Mike, apply the same fix to the related local
>   variables in gather_surplus_pages().
> ---
> ---
>  mm/hugetlb.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

Thank you,

Reviewed-by: Mike Kravetz <mike.kravetz@...cle.com>

-- 
Mike Kravetz