linux-kernel - Re: [PATCH net] bnxt_en: fix error return code in bnxt_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Nov 2020 10:53:47 -0800
From:   Edwin Peer <edwin.peer@...adcom.com>
To:     Zhang Changzhong <zhangchangzhong@...wei.com>
Cc:     Michael Chan <michael.chan@...adcom.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] bnxt_en: fix error return code in bnxt_init_one()

On Wed, Nov 18, 2020 at 4:17 AM Zhang Changzhong
<zhangchangzhong@...wei.com> wrote:

> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: c213eae8d3cd ("bnxt_en: Improve VF/PF link change logic.")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@...wei.com>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index 7c21aaa8..092775e 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -12674,6 +12674,7 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>                                 create_singlethread_workqueue("bnxt_pf_wq");
>                         if (!bnxt_pf_wq) {
>                                 dev_err(&pdev->dev, "Unable to create workqueue.\n");
> +                               rc = -ENOMEM;
>                                 goto init_err_pci_clean;
>                         }
>                 }
> --

Reviewed-by: Edwin Peer <edwin.peer@...adcom.com>

Regards,
Edwin Peer

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4160 bytes)