linux-kernel - Re: [PATCH] memory: tegra30-emc: Remove unnecessary of_node_put in tegra_emc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c8b53ce5-4fb8-e634-d4a6-baf00ae2e6a8@gmail.com>
Date:   Thu, 19 Nov 2020 23:00:26 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Nathan Chancellor <natechancellor@...il.com>,
        Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
        clang-built-linux@...glegroups.com
Subject: Re: [PATCH] memory: tegra30-emc: Remove unnecessary of_node_put in
 tegra_emc_probe

19.11.2020 22:52, Nathan Chancellor пишет:
> Clang warns:
> 
> drivers/memory/tegra/tegra30-emc.c:1275:15: warning: variable 'np' is
> uninitialized when used here [-Wuninitialized]
>                 of_node_put(np);
>                             ^~
> drivers/memory/tegra/tegra30-emc.c:1269:24: note: initialize the
> variable 'np' to silence this warning
>         struct device_node *np;
>                               ^
>                                = NULL
> 1 warning generated.
> 
> There does not need to be an of_node_put call in this error handling
> block after the shuffling of the np assignment. Remove it so there is
> no use of uninitialized memory.
> 
> Fixes: 5e00fd90183a ("memory: tegra30-emc: Continue probing if timings are missing in device-tree")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1203
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> ---
>  drivers/memory/tegra/tegra30-emc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/memory/tegra/tegra30-emc.c b/drivers/memory/tegra/tegra30-emc.c
> index 3488786da03b..93f9002d32ad 100644
> --- a/drivers/memory/tegra/tegra30-emc.c
> +++ b/drivers/memory/tegra/tegra30-emc.c
> @@ -1271,10 +1271,8 @@ static int tegra_emc_probe(struct platform_device *pdev)
>  	int err;
>  
>  	emc = devm_kzalloc(&pdev->dev, sizeof(*emc), GFP_KERNEL);
> -	if (!emc) {
> -		of_node_put(np);
> +	if (!emc)
>  		return -ENOMEM;
> -	}
>  
>  	emc->mc = devm_tegra_memory_controller_get(&pdev->dev);
>  	if (IS_ERR(emc->mc))
> 
> base-commit: 5e00fd90183ab0103b9f403ce73cb8407ebeb145
> 

Reviewed-by: Dmitry Osipenko <digetx@...il.com>