linux-kernel - Re: [PATCH -next] scsi: lpfc: Mark lpfc_nvmet_prep_abort

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cf37197a-7393-a3fb-e955-94cc1c0f0522@broadcom.com>
Date:   Thu, 19 Nov 2020 12:51:26 -0800
From:   James Smart <james.smart@...adcom.com>
To:     Zou Wei <zou_wei@...wei.com>, dick.kennedy@...adcom.com,
        jejb@...ux.ibm.com, martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] scsi: lpfc: Mark lpfc_nvmet_prep_abort_wqe with
 static keyword

On 11/17/2020 11:42 PM, Zou Wei wrote:
> Fix the following sparse warning:
>
> drivers/scsi/lpfc/lpfc_nvmet.c:3340:1: warning: symbol 'lpfc_nvmet_prep_abort_wqe' was not declared. Should it be static?
>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>
> ---
>   drivers/scsi/lpfc/lpfc_nvmet.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c
> index c8b9434..a71df87 100644
> --- a/drivers/scsi/lpfc/lpfc_nvmet.c
> +++ b/drivers/scsi/lpfc/lpfc_nvmet.c
> @@ -3336,7 +3336,7 @@ lpfc_nvmet_unsol_issue_abort(struct lpfc_hba *phba,
>    *
>    * This function is called with hbalock held.
>    **/
> -void
> +static void
>   lpfc_nvmet_prep_abort_wqe(struct lpfc_iocbq *pwqeq, u16 xritag, u8 opt)
>   {
>   	union lpfc_wqe128 *wqe = &pwqeq->wqe;

Zou, Thank You .  I just submitted the same patch.   Either one Martin 
wants to take.. :)

-- james

Reviewed-by: James Smart <james.smart@...adcom.com>


Download attachment "smime.p7s" of type "application/pkcs7-signature" (4163 bytes)