linux-kernel - Re: [PATCH v3 15/23] mtd: rawnand: diskonchip: Marking unused variables as __always

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20201119210837.25727-1-miquel.raynal@bootlin.com>
Date:   Thu, 19 Nov 2020 22:08:37 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Miquel Raynal <miquel.raynal@...tlin.com>,
        Dan Brown <dan_brown@...e.org>,
        Vignesh Raghavendra <vigneshr@...com>,
        Richard Weinberger <richard@....at>,
        linux-kernel@...r.kernel.org,
        Boris Brezillon <boris.brezillon@...labora.com>,
        linux-mtd@...ts.infradead.org,
        Thomas Gleixner <tglx@...utronix.de>,
        David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH v3 15/23] mtd: rawnand: diskonchip: Marking unused variables as __always_unused

On Mon, 2020-11-09 at 18:21:58 UTC, Lee Jones wrote:
> 'dummy' is never checked (as per the nomenclature) and the use of
> 'emtpymatch' is currently #if 0'ed out.  We could also #if 0 the
> declaration, but #ifery is pretty ugly, so I like to keep it to a
> minimum.
> 
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/mtd/nand/raw/diskonchip.c: In function ‘DoC_Delay’:
>  drivers/mtd/nand/raw/diskonchip.c:219:16: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable]
>  drivers/mtd/nand/raw/diskonchip.c: In function ‘doc200x_calculate_ecc’:
>  drivers/mtd/nand/raw/diskonchip.c:706:6: warning: variable ‘emptymatch’ set but not used [-Wunused-but-set-variable]
> 
> Cc: Miquel Raynal <miquel.raynal@...tlin.com>
> Cc: Richard Weinberger <richard@....at>
> Cc: Vignesh Raghavendra <vigneshr@...com>
> Cc: Boris Brezillon <boris.brezillon@...labora.com>
> Cc: Dan Brown <dan_brown@...e.org>
> Cc: David Woodhouse <dwmw2@...radead.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: linux-mtd@...ts.infradead.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel