linux-kernel - Re: [PATCH] mtd: rawnand: ingenic: remove redundant get_device() in ingenic_ecc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20201119211142.31720-1-miquel.raynal@bootlin.com>
Date:   Thu, 19 Nov 2020 22:11:42 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Yu Kuai <yukuai3@...wei.com>, paul@...pouillou.net,
        harveyhuntnexus@...il.com, miquel.raynal@...tlin.com,
        vigneshr@...com
Cc:     linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        yi.zhang@...wei.com
Subject: Re: [PATCH] mtd: rawnand: ingenic: remove redundant get_device() in ingenic_ecc_get()

On Sat, 2020-10-31 at 10:54:39 UTC, Yu Kuai wrote:
> of_find_device_by_node() already takes a reference to the device, and
> ingenic_ecc_release() will drop the reference. So, the get_device() in
> ingenic_ecc_get() is redundand.
> 
> Fixes: 15de8c6efd0e("mtd: rawnand: ingenic: Separate top-level and SoC specific code")
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>
> Acked-by: Paul Cercueil <paul@...pouillou.net>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel