linux-kernel - Re: [PATCH 1/1] pci: pciehp: Handle MRL interrupts to enable slot for hotplug.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201119222741.GA206150@bjorn-Precision-5520>
Date:   Thu, 19 Nov 2020 16:27:41 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     "Raj, Ashok" <ashok.raj@...el.com>
Cc:     Lukas Wunner <lukas@...ner.de>, linux-pci@...r.kernel.org,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@...el.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] pci: pciehp: Handle MRL interrupts to enable slot
 for hotplug.

Hi Ashok,

When you update this patch, can you run "git log --oneline
drivers/pci/hotplug/pciehp*" and make yours match?  It is a severe
character defect of mine, but seeing subject lines that are obviously
different than the convention is a disincentive to look at the patch.

On Thu, Nov 19, 2020 at 02:08:07PM -0800, Raj, Ashok wrote:
> On Thu, Nov 19, 2020 at 08:51:20AM +0100, Lukas Wunner wrote:
> > Hi Ashok,
> > 
> > my sincere apologies for the delay.
> 
> No worries.. 
> 
> > 
> > On Fri, Sep 25, 2020 at 04:01:38PM -0700, Ashok Raj wrote:
> > > When Mechanical Retention Lock (MRL) is present, Linux doesn't process
> > > those change events.
> > > 
> > > The following changes need to be enabled when MRL is present.
> > > 
> > > 1. Subscribe to MRL change events in SlotControl.
> > > 2. When MRL is closed,
> > >    - If there is no ATTN button, then POWER on the slot.
> > >    - If there is ATTN button, and an MRL event pending, ignore
> > >      Presence Detect. Since we want ATTN button to drive the
> > >      hotplug event.