linux-kernel - Re: [PATCH] selftests/seccomp: powerpc: Fix typo in macro variable name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 Nov 2020 17:03:34 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org
Cc:     Kees Cook <keescook@...omium.org>,
        Thadeu Lima de Souza Cascardo <cascardo@...onical.com>,
        Andy Lutomirski <luto@...capital.net>,
        Will Drewry <wad@...omium.org>, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] selftests/seccomp: powerpc: Fix typo in macro variable name

Kees Cook <keescook@...omium.org> writes:
> A typo sneaked into the powerpc selftest. Fix the name so it builds again.
>
> Fixes: 46138329faea ("selftests/seccomp: powerpc: Fix seccomp return value testing")
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
>  tools/testing/selftests/seccomp/seccomp_bpf.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I hit that and thought I'd sent a patch for it, but seems I never
actually sent it.

So thanks. I assume Shuah will take it.

Acked-by: Michael Ellerman <mpe@...erman.id.au>

cheers


> diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c
> index 76c458055c54..26c72f2b61b1 100644
> --- a/tools/testing/selftests/seccomp/seccomp_bpf.c
> +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c
> @@ -1758,10 +1758,10 @@ TEST_F(TRACE_poke, getpid_runs_normally)
>  		 * and the code is stored as a positive value.	\
>  		 */						\
>  		if (_result < 0) {				\
> -			SYSCALL_RET(_regs) = -result;		\
> +			SYSCALL_RET(_regs) = -_result;		\
>  			(_regs).ccr |= 0x10000000;		\
>  		} else {					\
> -			SYSCALL_RET(_regs) = result;		\
> +			SYSCALL_RET(_regs) = _result;		\
>  			(_regs).ccr &= ~0x10000000;		\
>  		}						\
>  	} while (0)
> -- 
> 2.25.1