linux-kernel - Re: [RFC PATCH v4] sched/fair: select idle cpu from idle cpumask for task wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bf7b6dd3-7922-2a4e-8df5-735b24c2dfc7@linux.intel.com>
Date:   Thu, 19 Nov 2020 09:13:09 +0800
From:   "Li, Aubrey" <aubrey.li@...ux.intel.com>
To:     Valentin Schneider <valentin.schneider@....com>
Cc:     mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, mgorman@...hsingularity.net,
        qais.yousef@....com, dietmar.eggemann@....com, rostedt@...dmis.org,
        bsegall@...gle.com, tim.c.chen@...ux.intel.com,
        linux-kernel@...r.kernel.org, Aubrey Li <aubrey.li@...el.com>,
        Mel Gorman <mgorman@...e.de>, Jiang Biao <benbjiang@...il.com>
Subject: Re: [RFC PATCH v4] sched/fair: select idle cpu from idle cpumask for
 task wakeup

On 2020/11/18 20:06, Valentin Schneider wrote:
> 
> On 16/11/20 20:04, Aubrey Li wrote:
>> From: Aubrey Li <aubrey.li@...el.com>
>>
>> Add idle cpumask to track idle cpus in sched domain. When a CPU
>> enters idle, if the idle driver indicates to stop tick, this CPU
>> is set in the idle cpumask to be a wakeup target. And if the CPU
>> is not in idle, the CPU is cleared in idle cpumask during scheduler
>> tick to ratelimit idle cpumask update.
>>
>> When a task wakes up to select an idle cpu, scanning idle cpumask
>> has low cost than scanning all the cpus in last level cache domain,
>> especially when the system is heavily loaded.
>>
>> Benchmarks were tested on a x86 4 socket system with 24 cores per
>> socket and 2 hyperthreads per core, total 192 CPUs. Hackbench and
>> schbench have no notable change, uperf has:
>>
>> uperf throughput: netperf workload, tcp_nodelay, r/w size = 90
>>
>>   threads       baseline-avg    %std    patch-avg       %std
>>   96            1               0.83    1.23            3.27
>>   144           1               1.03    1.67            2.67
>>   192           1               0.69    1.81            3.59
>>   240           1               2.84    1.51            2.67
>>
>> Cc: Mel Gorman <mgorman@...e.de>
>> Cc: Vincent Guittot <vincent.guittot@...aro.org>
>> Cc: Qais Yousef <qais.yousef@....com>
>> Cc: Valentin Schneider <valentin.schneider@....com>
>> Cc: Jiang Biao <benbjiang@...il.com>
>> Cc: Tim Chen <tim.c.chen@...ux.intel.com>
>> Signed-off-by: Aubrey Li <aubrey.li@...ux.intel.com>
> 
> That's missing a v3 -> v4 change summary
> 

okay, I'll add in the next version soon.

Thanks,
-Aubrey