linux-kernel - Re: [PATCH v7 3/7] kernel: Implement selective syscall userspace redirection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201119123602.GK3121392@hirez.programming.kicks-ass.net>
Date:   Thu, 19 Nov 2020 13:36:02 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Gabriel Krisman Bertazi <krisman@...labora.com>
Cc:     luto@...nel.org, tglx@...utronix.de, keescook@...omium.org,
        christian.brauner@...ntu.com, willy@...radead.org,
        shuah@...nel.org, linux-kernel@...r.kernel.org,
        linux-api@...r.kernel.org, linux-kselftest@...r.kernel.org,
        x86@...nel.org, gofmanp@...il.com, kernel@...labora.com
Subject: Re: [PATCH v7 3/7] kernel: Implement selective syscall userspace
 redirection

On Tue, Nov 17, 2020 at 10:28:36PM -0500, Gabriel Krisman Bertazi wrote:
>   prctl(PR_SET_SYSCALL_USER_DISPATCH, <op>, <off>, <length>, [selector])
> 
> The range [<offset>,<offset>+len] is a part of the process memory map

> +	if (likely(instruction_pointer(regs) - sd->offset < sd->len))
> +		return false;

The actual implementation ^ is: [<offset>, <offset>+<length>).

Which seems consistent and right, so I would suggest simply changing the
Changelog, something that could be done when applying.