linux-kernel - Re: [PATCH v4 2/4] tools/bootconfig: Fix to check the write failure correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201119085902.05df502b@gandalf.local.home>
Date:   Thu, 19 Nov 2020 08:59:02 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Chen Yu <yu.c.chen@...el.com>,
        Chen Yu <yu.chen.surf@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH v4 2/4] tools/bootconfig: Fix to check the write failure
 correctly

On Thu, 19 Nov 2020 10:41:09 +0900
Masami Hiramatsu <mhiramat@...nel.org> wrote:

> > If the first write fails (doesn't modify the initrd), and then this fails,
> > you will show a message of: "may be corrupted. Recommend to rebuild", when
> > that would not be the case. Should a test of the size be done again, to see
> > if it is already the same?  
> 
> Please see the above 2 write error check. You can find
> 
> if (ret < 0)
> 	goto out;
> 
> only in the first check. (I know, it might a bit misleadable)
> So, the first write is failed with error message, it doesn't call rollback.

Ah right, I missed check within the error check. I was only looking at the
first error and the goto at the end.

-- Steve