linux-kernel - Re: [PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE+NS36rnHzhdk5Os+vL=uK225HJT-bUHSRJ6KccaOHc-kCjpA@mail.gmail.com>
Date:   Thu, 19 Nov 2020 10:20:02 +0800
From:   Gene Chen <gene.chen.richtek@...il.com>
To:     Pavel Machek <pavel@....cz>
Cc:     Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Dan Murphy <dmurphy@...com>,
        Linux LED Subsystem <linux-leds@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Gene Chen <gene_chen@...htek.com>, Wilma.Wu@...iatek.com,
        shufan_lee@...htek.com, cy_huang@...htek.com,
        benjamin.chao@...iatek.com
Subject: Re: [PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions

Pavel Machek <pavel@....cz> 於 2020年11月19日 週四 上午5:37寫道：
>
> Hi!
>
> > From: Gene Chen <gene_chen@...htek.com>
> >
> > Add LED_COLOR_ID_MOONLIGHT definitions
>
> Why is moonlight a color? Camera flashes are usually white, no?
>
> At least it needs a comment...
>
> Best regards,
>                                                                 Pavel
>

Moonlight has more current level(150mA) from general RGB LED (24mA).
It can be used as night-light and usually use color AMBER.
Camera flashes are usually use two flash LED. One is YELLOW, and one is WHITE.

>
>
> > Signed-off-by: Gene Chen <gene_chen@...htek.com>
> > ---
> >  include/dt-bindings/leds/common.h | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
> > index 52b619d..1409e9a 100644
> > --- a/include/dt-bindings/leds/common.h
> > +++ b/include/dt-bindings/leds/common.h
> > @@ -33,7 +33,8 @@
> >  #define LED_COLOR_ID_MULTI   8       /* For multicolor LEDs */
> >  #define LED_COLOR_ID_RGB     9       /* For multicolor LEDs that can do arbitrary color,
> >                                          so this would include RGBW and similar */
> > -#define LED_COLOR_ID_MAX     10
> > +#define LED_COLOR_ID_MOONLIGHT       10
> > +#define LED_COLOR_ID_MAX     11
> >
> >  /* Standard LED functions */
> >  /* Keyboard LEDs, usually it would be input4::capslock etc. */
>
> --
> http://www.livejournal.com/~pavelmachek