linux-kernel - Re: [PATCH] USB: quirks: Add USB_QUIRK_DISCONNECT_SUSPEND quirk forLenovo A630Z TIO built-in usb-audio card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X7Z/+Tehbmx54Fzb@kroah.com>
Date:   Thu, 19 Nov 2020 15:23:53 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     彭浩 <penghao@...ontech.com>,
        johan <johan@...nel.org>, jonathan <jonathan@...ox.net>,
        tomasz <tomasz@...esinski.eu>,
        Hans de Goede <hdegoede@...hat.com>,
        dlaz <dlaz@...omium.org>,
        "richard.o.dodd" <richard.o.dodd@...il.com>,
        kerneldev <kerneldev@...smulder.nl>,
        linux-usb <linux-usb@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] USB: quirks: Add USB_QUIRK_DISCONNECT_SUSPEND quirk
 forLenovo A630Z TIO built-in usb-audio card

On Thu, Nov 19, 2020 at 10:12:02PM +0800, Kai-Heng Feng wrote:
> 
> 
> > On Nov 19, 2020, at 21:59, Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
> > 
> > On Thu, Nov 19, 2020 at 09:41:32PM +0800, Kai-Heng Feng wrote:
> >> Hi penghao,
> >> 
> >>> On Nov 19, 2020, at 20:17, 彭浩 <penghao@...ontech.com> wrote:
> >>> 
> >>> root@...-PC:/sys/bus/usb/devices/usb7# dmesg
> >>> [ 0.000000] Linux version 4.19.0-6-amd64 (debian-kernel@...ts.debian.org) (gcc version 8.3.0 (Debian 8.3.0-6)) #1 SMP Uos 4.19.67-11eagle (2020-03-21)
> >> 
> >> Thanks for the dmesg. But would it be possible to use mainline kernel enable dynamic debug?
> >> 
> >> But anyway, this is not a regular AMD or Intel platform, so I guess we can merge the quirk as is...
> >> 
> >> Kai-Heng
> >> 
> >>> [ 0.000000] Command line: BOOT_IMAGE=/boot/vmlinuz-4.19.0-6-amd64 root=UUID=e5a40c4f-d88e-4a4d-9414-a27892a31be7 ro splash console=ttyS0,115200n8 loglevel=7 DEEPIN_GFXMODE=0,1920x1080,1600x1200,1280x1024,1024x768
> >>> [ 0.000000] Zhaoxin Linux Patch Version is V3.0.2 
> >>> [ 0.000000] With Zhaoxin Shanghai CPU patch V2.0.0
> > 
> > What do you mean "not a regular"?  This is an x86-variant chip platform,
> > but what does that have to do with the USB quirk detection?
> 
> USB quirk detection should work fine. I was trying to find the root cause, but seeing it's a Zhaoxin CPU, that could be the reason why mainline kernel, which has many USB power management fixes, wasn't used.
> 
> penghao, is it possible to boot mainline kernel on Zhaoxin CPU?

There have been a number of small patches for this type of CPU merged
over the past months, so I hope a mainline kernel works here :)

That being said, why would the platform matter for a USB device quirk?

thanks,

greg k-h