linux-kernel - Re: [PATCH] scsi: ufs: Make sure clk scaling happens only when hba is runtime ACTIVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <160579821161.27938.15426150263135159232.b4-ty@oracle.com>
Date:   Thu, 19 Nov 2020 10:03:41 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     salyzyn@...gle.com, kernel-team@...roid.com,
        nguyenb@...eaurora.org, hongwus@...eaurora.org,
        saravanak@...gle.com, asutoshd@...eaurora.org,
        Can Guo <cang@...eaurora.org>, rnayak@...eaurora.org,
        linux-scsi@...r.kernel.org
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        Avri Altman <avri.altman@....com>,
        Stanley Chu <stanley.chu@...iatek.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        open list <linux-kernel@...r.kernel.org>,
        Bean Huo <beanhuo@...ron.com>,
        Bart Van Assche <bvanassche@....org>,
        Alim Akhtar <alim.akhtar@...sung.com>
Subject: Re: [PATCH] scsi: ufs: Make sure clk scaling happens only when hba is runtime ACTIVE

On Tue, 22 Sep 2020 00:09:04 -0700, Can Guo wrote:

> If someone plays with the UFS clk scaling devfreq governor through sysfs,
> ufshcd_devfreq_scale may be called even when hba is not runtime ACTIVE,
> which can lead to unexpected error. We cannot just protect it by calling
> pm_runtime_get_sync, because that may cause racing problem since hba
> runtime suspend ops needs to suspend clk scaling. In order to fix it, call
> pm_runtime_get_noresume and check hba's runtime status, then only proceed
> if hba is runtime ACTIVE, otherwise just bail.
> 
> [...]

Applied to 5.10/scsi-fixes, thanks!

[1/1] scsi: ufs: Make sure clk scaling happens only when HBA is runtime ACTIVE
      https://git.kernel.org/mkp/scsi/c/73cc291c2702

-- 
Martin K. Petersen	Oracle Linux Engineering