linux-kernel - Re: [PATCH v9 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Nov 2020 23:33:37 +0800
From:   kernel test robot <lkp@...el.com>
To:     Pavana Sharma <pavana.sharma@...i.com>, kuba@...nel.org
Cc:     kbuild-all@...ts.01.org, andrew@...n.ch, ashkan.boldaji@...i.com,
        davem@...emloft.net, f.fainelli@...il.com,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        marek.behun@....cz, netdev@...r.kernel.org, pavana.sharma@...i.com
Subject: Re: [PATCH v9 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x
 family of Marvell

Hi Pavana,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on net-next/master net/master linus/master v5.10-rc4 next-20201119]
[cannot apply to sparc-next/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Pavana-Sharma/Add-support-for-mv88e6393x-family-of-Marvell/20201119-160915
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/2b347d8ede029475baf73ac8e08ea38dad2526e4
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Pavana-Sharma/Add-support-for-mv88e6393x-family-of-Marvell/20201119-160915
        git checkout 2b347d8ede029475baf73ac8e08ea38dad2526e4
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/dsa/mv88e6xxx/serdes.c: In function 'mv88e6393x_serdes_power':
>> drivers/net/dsa/mv88e6xxx/serdes.c:1212:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
    1212 |  u8 cmode = chip->ports[port].cmode;
         |  ^~

vim +1212 drivers/net/dsa/mv88e6xxx/serdes.c

  1205	
  1206	int mv88e6393x_serdes_power(struct mv88e6xxx_chip *chip, int port, int lane,
  1207			    bool on)
  1208	{
  1209		if (port != 0 && port != 9 && port != 10)
  1210			return -EOPNOTSUPP;
  1211	
> 1212		u8 cmode = chip->ports[port].cmode;

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (53575 bytes)