linux-kernel - Re: [PATCH 2/2] arm64: dts: ti: k3-j7200-common-proc-board: Correct the name of io expander on main

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc2f740a-e53e-d612-0ec7-e69bf8228e71@ti.com>
Date:   Thu, 19 Nov 2020 21:40:57 +0530
From:   Vignesh Raghavendra <vigneshr@...com>
To:     Peter Ujfalusi <peter.ujfalusi@...com>, <nm@...com>,
        <t-kristo@...com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <nsekhar@...com>
Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-j7200-common-proc-board: Correct
 the name of io expander on main_i2c1



On 11/19/20 6:56 PM, Peter Ujfalusi wrote:
> J7200 main_i2c1 is connected to the i2c bus on the CPB marked as main_i2c3
> 
> The i2c1 devices on the CPB are _not_ connected to the SoC, they are not
> usable with the J7200 SOM.
> 
> Correct the expander name from exp4 to exp3 and at the same time add the
> line names as well.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
> ---

Yes, the schematics call this expander as exp3. Thanks for the fix

Reviewed-by: Vignesh Raghavendra <vigneshr@...com>

>  arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> index 2721137d8943..83e043c65f81 100644
> --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> @@ -159,11 +159,14 @@ &main_i2c1 {
>  	pinctrl-0 = <&main_i2c1_pins_default>;
>  	clock-frequency = <400000>;
>  
> -	exp4: gpio@20 {
> +	exp3: gpio@20 {
>  		compatible = "ti,tca6408";
>  		reg = <0x20>;
>  		gpio-controller;
>  		#gpio-cells = <2>;
> +		gpio-line-names = "CODEC_RSTz", "CODEC_SPARE1", "UB926_RESETn",
> +				  "UB926_LOCK", "UB926_PWR_SW_CNTRL",
> +				  "UB926_TUNER_RESET", "UB926_GPIO_SPARE", "";

I assume these lines have same meaning in J721e and J7200? If so, then
no issues.

>  	};
>  };
>  
>