linux-kernel - Re: [PATCH v2 2/4] clk: qcom: Add SDX55 GCC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <160575623386.2717324.1766580531259003708@swboyd.mtv.corp.google.com>
Date:   Wed, 18 Nov 2020 19:23:53 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc:     Vinod Koul <vkoul@...nel.org>, mturquette@...libre.com,
        robh+dt@...nel.org, bjorn.andersson@...aro.org,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Naveen Yadav <naveenky@...eaurora.org>
Subject: Re: [PATCH v2 2/4] clk: qcom: Add SDX55 GCC support

Quoting Manivannan Sadhasivam (2020-11-18 06:44:01)
> On Sat, Nov 14, 2020 at 12:35:27PM -0800, Stephen Boyd wrote:
> > Quoting Vinod Koul (2020-11-06 01:38:19)
> > > On 05-11-20, 16:18, Manivannan Sadhasivam wrote:
> > > > +#include "reset.h"
> > > > +
> > > > +enum {
> > > > +     P_BI_TCXO,
> > > > +     P_CORE_BI_PLL_TEST_SE,
> > > 
> > > This is for test and we removed this for upstream, so can you do that as
> > > well (not parent will decrease for clks below)
> > > 
> > > With that updated:
> > > 
> > > Reviewed-by: Vinod Koul <vkoul@...nel.org>
> > > 
> > 
> > I half understood that. Just an FYI that I'm waiting for this update.
> 
> Looks like this change is not needed. Can you please consider merging
> this series?
> 

No. Please document core_bi_pll_test_se in the binding.