linux-kernel - RE: [PATCH v1] docs: ACPI: enumeration: add PCI hierarchy representation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 Nov 2020 16:17:19 +0000
From:   Flavio Suligoi <f.suligoi@...m.it>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC:     "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v1] docs: ACPI: enumeration: add PCI hierarchy
 representation

Hi Andy!


> On Thu, Nov 19, 2020 at 11:12:33AM +0100, Flavio Suligoi wrote:
> 
> Thank you very much for nice piece of documentation!
> My comments below.

Thanks for your suggestions! I'll use them in the next version
of the patch!

> > +particular the DSDT (see also [2])::
> 
> > +	cd /sys/firmware/acpi
> > +	cp -a tables/ ~
> > +	cd ~/tables/
> 
> acpidump followed by acpixtract from ACPI tools is better to advertise.

Ok, I'll use acpixtract

> 
> > +	find . -type f -exec mv {} {}.aml \;
> 
> Unnecessary step. But I think you wanted to have it to distinguish sources
> and
> binaries in the text below.

Right, I think that is important include the SSDT tables for external
symbol resolution. For this reason I renamed the binary tables, to
use the following command:

> > +	iasl -e SSDT?.* -d DSDT.aml

> --
> With Best Regards,
> Andy Shevchenko
> 

Best regards,
Flavio