linux-kernel - Re: [PATCH] seccomp: Remove bogus _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAG48ez22JooyfTbPkhhfU15Oo3vcRr-bc1d3SQV1aGFaQuwVfA@mail.gmail.com>
Date:   Fri, 20 Nov 2020 16:45:46 +0100
From:   Jann Horn <jannh@...gle.com>
To:     Tyler Hicks <code@...icks.com>
Cc:     Kees Cook <keescook@...omium.org>,
        Andy Lutomirski <luto@...capital.net>,
        Will Drewry <wad@...omium.org>,
        kernel list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] seccomp: Remove bogus __user annotations

On Fri, Nov 20, 2020 at 4:36 PM Tyler Hicks <code@...icks.com> wrote:
> Hey Jann - Thanks for cleaning this up!
>
> On 2020-11-20 02:59:13, Jann Horn wrote:
> > Buffers that are passed to read_actions_logged() and write_actions_logged()
> > are in kernel memory; the sysctl core takes care of copying from/to
> > userspace.
> >
> > Fixes: 0ddec0fc8900 ("seccomp: Sysctl to configure actions that are allowed to be logged")
>
> After tracing back through the code, I was struggling to understand why
> I thought the __user annotation was needed back then. It turns out that
> __user was correct when I wrote 0ddec0fc8900 and that the Fixes tag
> should be changed to this:
>
>  Fixes: 32927393dc1c ("sysctl: pass kernel pointers to ->proc_handler")
>
> If you agree, please adjust and resubmit with:
>
>  Reviewed-by: Tyler Hicks <code@...icks.com>
>
> Thank you!

Aaaah, that makes sense. Thanks, will do.