lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 20 Nov 2020 16:55:00 +0100
From:   Paolo Bonzini <>
To:     Daniel Vetter <>
Cc:     DRI Development <>,
        LKML <>,
        KVM list <>, Linux MM <>,
        Linux ARM <>,
        linux-samsung-soc <>,
        Daniel Vetter <>,
        Christoph Hellwig <>,
        Jason Gunthorpe <>,
        Kees Cook <>,
        Dan Williams <>,
        Andrew Morton <>,
        John Hubbard <>,
        Jérôme Glisse <>,
        Jan Kara <>
Subject: Re: [PATCH v6 16/17] RFC: kvm: pass kvm argument to follow_pfn

On 20/11/20 16:44, Daniel Vetter wrote:
>> It's a bit of a pity, it's making an API more complex (the point of
>> gfn_to_pfn_memslot vs gfn_to_pfn is exactly that you don't need a
>> "struct kvm*" and it's clear that you've already done the lookup into
>> that struct kvm.
> Yeah I noticed that, I think pushing the lookups down should work, but
> that's a fairly large-scale change. I didn't want to do that for the
> RFC since it would distract from the actual change/goal.
> -Daniel

Pushing the lookups down would be worse code and possibly introduce 
TOC/TOU races, so better avoid that.  Your patch is fine. :)


Powered by blists - more mailing lists