linux-kernel - Re: [PATCH 1/4] x86/mce: do not overwrite no_way_out if mce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201120173342.GF712@zn.tnic>
Date:   Fri, 20 Nov 2020 18:33:42 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     "Paoloni, Gabriele" <gabriele.paoloni@...el.com>
Cc:     "Luck, Tony" <tony.luck@...el.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "x86@...nel.org" <x86@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-safety@...ts.elisa.tech" <linux-safety@...ts.elisa.tech>
Subject: Re: [PATCH 1/4] x86/mce: do not overwrite no_way_out if mce_end()
 fails

On Fri, Nov 20, 2020 at 05:31:32PM +0000, Paoloni, Gabriele wrote:
> I mean that on this CPU thread at this point mce_start() already cached
> global_nwo and hence could accumulate fatal severities of other CPUs.
> 
> Now here if mce_end() fails we only consider the local 'worst' severity
> and we overwrite those already cached.

Yap, we're on the same page. :)

> If ok I will fix the grammar and rewrite this code in v2.

Sure, lemme go through the rest first.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette