linux-kernel - Re: [PATCH 03/27] blk-iocost: use local[64]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X7g/pTLLJEQXdbD7@mtj.duckdns.org>
Date:   Fri, 20 Nov 2020 17:13:57 -0500
From:   Tejun Heo <tj@...nel.org>
To:     Stafford Horne <shorne@...il.com>
Cc:     axboe@...nel.dk, linux-block@...r.kernel.org,
        cgroups@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-team@...com, newella@...com
Subject: Re: [PATCH 03/27] blk-iocost: use local[64]_t for percpu stat

Hello,

On Sat, Nov 21, 2020 at 06:51:47AM +0900, Stafford Horne wrote:
> FYI, I am just noticing this but this breaks my allyesconfig build
> on OpenRISC; as 32-bit arch/openrisc doesn't define local64.h
> 
> In general local64 is slow on 32-bit architectures, would that
> be a problem with the usage here?  Are the calls to local64_*
> below on critical paths?

It gets hot when running on really high iops devices but that hopefully
isn't a problem for 32bit openrisc.

> Either way I will submit a patch in include generic local64.h
> on OpenRISC, I confirmed it fixes the build.  I do not know of anyone
> using cgroups on OpenRISC systems.

Yeah, sounds like the right fix.

Thanks.

-- 
tejun