lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 Nov 2020 14:48:50 +0800 From: Min Guo <min.guo@...iatek.com> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Bin Liu <b-liu@...com> CC: Matthias Brugger <matthias.bgg@...il.com>, <chunfeng.yun@...iatek.com>, <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, <linux-mediatek@...ts.infradead.org> Subject: Re: [PATCH] usb: musb: remove unused variable 'devctl' Hi greg k-h: On Wed, 2020-11-18 at 12:48 +0100, Greg Kroah-Hartman wrote: > On Tue, Nov 17, 2020 at 04:21:25PM +0800, min.guo@...iatek.com wrote: > > From: Min Guo <min.guo@...iatek.com> > > > > Remove unused 'devctl' variable to fix compile warnings: > > > > drivers/usb/musb/musbhsdma.c: In function 'dma_controller_irq': > > drivers/usb/musb/musbhsdma.c:324:8: warning: variable 'devctl' set > > but not used [-Wunused-but-set-variable] > > > > Signed-off-by: Min Guo <min.guo@...iatek.com> > > --- > > drivers/usb/musb/musbhsdma.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/drivers/usb/musb/musbhsdma.c b/drivers/usb/musb/musbhsdma.c > > index 0aacfc8be5a1..7acd1635850d 100644 > > --- a/drivers/usb/musb/musbhsdma.c > > +++ b/drivers/usb/musb/musbhsdma.c > > @@ -321,8 +321,6 @@ irqreturn_t dma_controller_irq(int irq, void *private_data) > > musb_channel->channel.status = > > MUSB_DMA_STATUS_BUS_ABORT; > > } else { > > - u8 devctl; > > - > > addr = musb_read_hsdma_addr(mbase, > > bchannel); > > channel->actual_len = addr > > @@ -336,8 +334,6 @@ irqreturn_t dma_controller_irq(int irq, void *private_data) > > < musb_channel->len) ? > > "=> reconfig 0" : "=> complete"); > > > > - devctl = musb_readb(mbase, MUSB_DEVCTL); > > Are you sure that the hardware does not require this read to complete > the command? Lots of hardware is that way, so be very careful about > this. Did you test it? I have tested this patch on Mediatek's platform, and not sure if it will affect other vendors' platforms. Dear Bin: Does this patch will affect other vendors' platforms? Best Regards, Min > thanks, > > greg k-h
Powered by blists - more mailing lists