linux-kernel - Re: [PATCH] firmware: xlnx-zynqmp: fix compilation warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f6719d16-9539-1046-28f4-7f9e82b8c6d1@xilinx.com>
Date:   Fri, 20 Nov 2020 10:14:52 +0100
From:   Michal Simek <michal.simek@...inx.com>
To:     Wendy Liang <wendy.liang@...inx.com>, <michal.simek@...inx.com>,
        <rajan.vaja@...inx.com>, <gregkh@...uxfoundation.org>,
        <tejas.patel@...inx.com>, <manish.narani@...inx.com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] firmware: xlnx-zynqmp: fix compilation warning



On 18. 11. 20 23:31, Wendy Liang wrote:
> Fix compilation warning when ZYNQMP_FIRMWARE is not defined.
> 
> include/linux/firmware/xlnx-zynqmp.h: In function
> 'zynqmp_pm_get_eemi_ops':
>  include/linux/firmware/xlnx-zynqmp.h:363:9: error: implicit
>  declaration of function 'ERR_PTR'
>  [-Werror=implicit-function-declaration]
>      363 |  return ERR_PTR(-ENODEV);
> 
> include/linux/firmware/xlnx-zynqmp.h:363:18: note: each undeclared
> identifier is reported only once for each function it appears in
>    include/linux/firmware/xlnx-zynqmp.h: In function
> 'zynqmp_pm_get_api_version':
>    include/linux/firmware/xlnx-zynqmp.h:367:10: error: 'ENODEV'
> undeclared (first use in this function)
>      367 |  return -ENODEV;
>          |          ^~~~~~

Are these issues caused by your AI driver?
If not, can you please point me to .config which reports this issue?

> 
> Signed-off-by: Wendy Liang <wendy.liang@...inx.com>
> ---
>  include/linux/firmware/xlnx-zynqmp.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h
> index 5968df8..7b6f9fc 100644
> --- a/include/linux/firmware/xlnx-zynqmp.h
> +++ b/include/linux/firmware/xlnx-zynqmp.h
> @@ -13,6 +13,10 @@
>  #ifndef __FIRMWARE_ZYNQMP_H__
>  #define __FIRMWARE_ZYNQMP_H__
>  
> +#if !IS_REACHABLE(CONFIG_ZYNQMP_FIRMWARE)

I don't think there is a real need to have this ifdef around.
You can just ignore it and keep just below line.

> +#include <linux/err.h>
> +#endif
> +
>  #define ZYNQMP_PM_VERSION_MAJOR	1
>  #define ZYNQMP_PM_VERSION_MINOR	0
>  
> 


Thanks,
Michal