linux-kernel - Re: [PATCH v3] USB: serial: mos7720: defer state restore to a workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <X7eOax2XYDMbySAa@localhost>
Date:   Fri, 20 Nov 2020 10:37:47 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Davidlohr Bueso <dave@...olabs.net>
Cc:     johan@...nel.org, dbueso@...e.de, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH v3] USB: serial: mos7720: defer state restore to a
 workqueue

On Thu, Nov 19, 2020 at 08:53:00PM -0800, Davidlohr Bueso wrote:
> The parallel port restore operation currently defers writes
> to a tasklet, if it sees a locked disconnect mutex. The
> driver goes to a lot of trouble to ensure writes happen
> in a non-blocking context, but things can be greatly
> simplified if it's done in regular process context and
> this is not a system performance critical path. As such,
> instead of doing the state restore writes in irq context,
> use a workqueue and just do regular synchronous writes.
> 
> In addition to the cleanup, this also imposes less on the
> overall system as tasklets have been deprecated because
> of it's softirq implications, potentially blocking a higher
> priority task from running.
> 
> Signed-off-by: Davidlohr Bueso <dbueso@...e.de>

Now applied, thanks!

Johan