linux-kernel - Re: [PATCH] x86/dumpstack: make show_trace_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <X7eRSzvm98AOk9pZ@alley>
Date:   Fri, 20 Nov 2020 10:50:03 +0100
From:   Petr Mladek <pmladek@...e.com>
To:     Hui Su <sh_def@....com>
Cc:     tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, x86@...nel.org,
        hpa@...or.com, 0x7f454c46@...il.com, jroedel@...e.de,
        akpm@...ux-foundation.org, jannh@...gle.com,
        mark.mossberg@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/dumpstack: make show_trace_log_lvl() static

On Fri 2020-11-13 21:39:43, Hui Su wrote:
> show_trace_log_lvl() won't be used by other files, so
> make it static and remove the declaration from the header
> file.
> 
> Signed-off-by: Hui Su <sh_def@....com>

I would make sense to add:

Fixes: 16d1cb0bc43642a4d9 ("x86/dumpstack: Unify show_regs()")

Othrewise, it looks good:

Reviewed-by: Petr Mladek <pmladek@...e.com>

Best Regards,
Petr