lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 Nov 2020 10:54:44 +0100 From: Daniel Vetter <daniel.vetter@...ll.ch> To: DRI Development <dri-devel@...ts.freedesktop.org> Cc: Intel Graphics Development <intel-gfx@...ts.freedesktop.org>, linux-mm@...ck.org, linux-xfs@...r.kernel.org, linux-fsdevel@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, Daniel Vetter <daniel.vetter@...ll.ch>, Dave Chinner <david@...morbit.com>, Qian Cai <cai@....pw>, Thomas Hellström <thomas_os@...pmail.org>, Andrew Morton <akpm@...ux-foundation.org>, Jason Gunthorpe <jgg@...lanox.com>, linux-rdma@...r.kernel.org, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Christian König <christian.koenig@....com>, "Matthew Wilcox (Oracle)" <willy@...radead.org>, Daniel Vetter <daniel.vetter@...el.com>, Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org> Subject: [PATCH 3/3] locking/selftests: Add testcases for fs_reclaim Since I butchered this I figured better to make sure we have testcases for this now. Since we only have a locking context for __GFP_FS that's the only thing we're testing right now. Cc: linux-fsdevel@...r.kernel.org Cc: Dave Chinner <david@...morbit.com> Cc: Qian Cai <cai@....pw> Cc: linux-xfs@...r.kernel.org Cc: Thomas Hellström (Intel) <thomas_os@...pmail.org> Cc: Andrew Morton <akpm@...ux-foundation.org> Cc: Jason Gunthorpe <jgg@...lanox.com> Cc: linux-mm@...ck.org Cc: linux-rdma@...r.kernel.org Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com> Cc: Christian König <christian.koenig@....com> Cc: "Matthew Wilcox (Oracle)" <willy@...radead.org> Signed-off-by: Daniel Vetter <daniel.vetter@...el.com> Cc: Peter Zijlstra <peterz@...radead.org> Cc: Ingo Molnar <mingo@...hat.com> Cc: Will Deacon <will@...nel.org> Cc: linux-kernel@...r.kernel.org --- lib/locking-selftest.c | 47 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) diff --git a/lib/locking-selftest.c b/lib/locking-selftest.c index a899b3f0e2e5..ad47c3358e30 100644 --- a/lib/locking-selftest.c +++ b/lib/locking-selftest.c @@ -15,6 +15,7 @@ #include <linux/mutex.h> #include <linux/ww_mutex.h> #include <linux/sched.h> +#include <linux/sched/mm.h> #include <linux/delay.h> #include <linux/lockdep.h> #include <linux/spinlock.h> @@ -2357,6 +2358,50 @@ static void queued_read_lock_tests(void) pr_cont("\n"); } +static void fs_reclaim_correct_nesting(void) +{ + fs_reclaim_acquire(GFP_KERNEL); + might_alloc(GFP_NOFS); + fs_reclaim_release(GFP_KERNEL); +} + +static void fs_reclaim_wrong_nesting(void) +{ + fs_reclaim_acquire(GFP_KERNEL); + might_alloc(GFP_KERNEL); + fs_reclaim_release(GFP_KERNEL); +} + +static void fs_reclaim_protected_nesting(void) +{ + unsigned int flags; + + fs_reclaim_acquire(GFP_KERNEL); + flags = memalloc_nofs_save(); + might_alloc(GFP_KERNEL); + memalloc_nofs_restore(flags); + fs_reclaim_release(GFP_KERNEL); +} + +static void fs_reclaim_tests(void) +{ + printk(" --------------------\n"); + printk(" | fs_reclaim tests |\n"); + printk(" --------------------\n"); + + print_testname("correct nesting"); + dotest(fs_reclaim_correct_nesting, SUCCESS, 0); + pr_cont("\n"); + + print_testname("wrong nesting"); + dotest(fs_reclaim_wrong_nesting, FAILURE, 0); + pr_cont("\n"); + + print_testname("protected nesting"); + dotest(fs_reclaim_protected_nesting, SUCCESS, 0); + pr_cont("\n"); +} + void locking_selftest(void) { /* @@ -2478,6 +2523,8 @@ void locking_selftest(void) if (IS_ENABLED(CONFIG_QUEUED_RWLOCKS)) queued_read_lock_tests(); + fs_reclaim_tests(); + if (unexpected_testcase_failures) { printk("-----------------------------------------------------------------\n"); debug_locks = 0; -- 2.29.2
Powered by blists - more mailing lists